Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

MCKIN-27715: add missing translations #232

Merged
merged 7 commits into from
Dec 4, 2020
Merged

MCKIN-27715: add missing translations #232

merged 7 commits into from
Dec 4, 2020

Conversation

msaqib52
Copy link
Contributor

@msaqib52 msaqib52 commented Dec 2, 2020 •
edited
Loading

@shafqatfarhan This PR adds some missing translations, could you please review it.

@openedx-webhooks
Copy link

openedx-webhooks commented Dec 2, 2020 •
edited
Loading

Thanks for the pull request, @msaqib52! I've created OSPR-5276 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link

natabene commented Dec 2, 2020

@msaqib52 Thank you for your contribution. Please let me know once it is ready for our review. @shafqatfarhan our team are owners of this repo, please review and merge once they are ready.

@msaqib52 msaqib52 changed the title WIP MCKIN-27715: add missing translations MCKIN-27715: add missing translations Dec 4, 2020
@msaqib52 msaqib52 changed the title MCKIN-27715: add missing translations WIP MCKIN-27715: add missing translations Dec 4, 2020
@msaqib52 msaqib52 changed the title WIP MCKIN-27715: add missing translations MCKIN-27715: add missing translations Dec 4, 2020
hasnain-naveed
hasnain-naveed approved these changes Dec 4, 2020
View reviewed changes
Copy link

@hasnain-naveed hasnain-naveed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@hasnain-naveed hasnain-naveed merged commit f117300 into openedx-unsupported:master Dec 4, 2020
@openedx-webhooks
Copy link

@msaqib52 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

msaqib52 added a commit to msaqib52/edx-notifications that referenced this pull request Dec 8, 2020
@msaqib52
MCKIN-27715: add missing translations (openedx-unsupported#232)
e21fead 
* mark missing strings for translations

* add missing translations

* bump version

* add japanese translations

* fix tests

* fix tests

* update translations
@msaqib52 msaqib52 mentioned this pull request Dec 8, 2020
Merged
hasnain-naveed pushed a commit that referenced this pull request Dec 9, 2020
@msaqib52
MCKIN-27715: add missing translations (#233)
ba8b3ea 
* MCKIN-27715: add missing translations (#232)

* mark missing strings for translations

* add missing translations

* bump version

* add japanese translations

* fix tests

* fix tests

* update translations

* bump version

* remove unused import
hasnain-naveed pushed a commit that referenced this pull request Jan 5, 2021
@msaqib52 @hasnain-naveed
MCKIN-27715: add missing translations (#233)
231d366 
* MCKIN-27715: add missing translations (#232)

* mark missing strings for translations

* add missing translations

* bump version

* add japanese translations

* fix tests

* fix tests

* update translations

* bump version

* remove unused import
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hasnain-naveed hasnain-naveed hasnain-naveed approved these changes

Assignees
No one assigned
Labels
merged open-source-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msaqib52 @openedx-webhooks @natabene @hasnain-naveed