Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lock): make import pool, create replica and share replica operations mutually exclusive #1611

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(lock): make import pool, create replica and share replica operations mutually exclusive #1611

merged 1 commit into from
Apr 8, 2024

Conversation

hrudaya21
Copy link
Contributor

@hrudaya21 hrudaya21 commented Mar 20, 2024 •
edited
Loading

  1. Current PR handles concurrent gRPC request of import pool, create replica, share replica. All are kept under resource mutex lock, where resource is pool_name.

@hrudaya21 hrudaya21 marked this pull request as ready for review March 20, 2024 16:49
@hrudaya21 hrudaya21 force-pushed the GTM-2094 branch 2 times, most recently from f59f496 to 3ef38b9 Compare March 21, 2024 15:04
dsharma-dc
dsharma-dc reviewed Mar 26, 2024
View reviewed changes
io-engine/src/bin/io-engine.rs Outdated Show resolved Hide resolved
io-engine/src/core/lock.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/pool.rs Outdated Show resolved Hide resolved
tiagolobocastro
tiagolobocastro reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to document what changes for each resource happened in the PR description

io-engine/src/bin/io-engine.rs Outdated Show resolved Hide resolved
io-engine/src/bin/io-engine.rs Outdated Show resolved Hide resolved
io-engine/src/bin/io-engine.rs Outdated Show resolved Hide resolved
io-engine/src/core/lock.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/pool.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/pool.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/replica.rs Outdated Show resolved Hide resolved
@hrudaya21 hrudaya21 force-pushed the GTM-2094 branch 2 times, most recently from 1b2ccf6 to 8172370 Compare March 29, 2024 12:02
@hrudaya21 hrudaya21 changed the title fix(grpc-lock): serialized read/write lock for grpc request fix(lock): make import pool, create replica and share replica operations mutually exclusive Mar 29, 2024
tiagolobocastro
tiagolobocastro reviewed Apr 2, 2024
View reviewed changes
io-engine/src/grpc/v1/replica.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/replica.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/replica.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/v1/replica.rs Outdated Show resolved Hide resolved
io-engine/src/lvs/lvs_error.rs Show resolved Hide resolved
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
@hrudaya21 hrudaya21 force-pushed the GTM-2094 branch 3 times, most recently from 958465b to 0af3c40 Compare April 5, 2024 05:47
tiagolobocastro
tiagolobocastro approved these changes Apr 5, 2024
View reviewed changes
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
@hrudaya21 hrudaya21 force-pushed the GTM-2094 branch 2 times, most recently from 61aef23 to 7854c7a Compare April 5, 2024 18:31
dsharma-dc
dsharma-dc approved these changes Apr 8, 2024
View reviewed changes
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
io-engine/src/grpc/mod.rs Outdated Show resolved Hide resolved
@hrudaya21 hrudaya21 force-pushed the GTM-2094 branch 2 times, most recently from 6480d8f to dbd9f92 Compare April 8, 2024 05:35
@hrudaya21
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Apr 8, 2024
Try #1611:
ed93d1e
@bors-openebs-mayastor
Copy link

try

Build failed:

@hrudaya21
fix(lock): make import pool, create replica and share replica operati…
9b90fb0 
…ons mutually exclusive

Signed-off-by: Hrudaya <hrudayaranjan.sahoo@datacore.com>
@hrudaya21
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Apr 8, 2024
Try #1611:
636ddf1
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@hrudaya21
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 68a847d into openebs:develop Apr 8, 2024
4 checks passed
@hrudaya21 hrudaya21 mentioned this pull request Apr 8, 2024
Merged
bors-openebs-mayastor bot pushed a commit that referenced this pull request Apr 8, 2024
@hrudaya21
Merge #1628
00f735d 
1628: fix(lock): make import pool, create replica and share replica operations mutually exclusive(cherry-pick PR) r=hrudaya21 a=hrudaya21

Cherry-pick PR of #1611 

Co-authored-by: Hrudaya <hrudayaranjan.sahoo@datacore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@dsharma-dc dsharma-dc dsharma-dc approved these changes

@dsavitskiy dsavitskiy Awaiting requested review from dsavitskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrudaya21 @tiagolobocastro @dsharma-dc