fix(nexus): fixing missing I/Os during nexus rebuild #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded: |
tiagolobocastro
approved these changes
Feb 1, 2024
dsavitskiy
force-pushed
the
feature/miscompare
branch
from
f8d5eda
to
37e25ae
Compare
|
bors try |
tryBuild succeeded: |
|
bors try |
tryBuild succeeded: |
hrudaya21
approved these changes
Feb 5, 2024
Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
dsavitskiy
force-pushed
the
feature/miscompare
branch
from
37e25ae
to
5a5abab
Compare
If a nexus was published after a rebuild started, the child being rebuilt was not added to writers. This caused I/Os missing the child, leading to a corrupted replica. Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
dsavitskiy
force-pushed
the
feature/miscompare
branch
from
5a5abab
to
ea4902c
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a nexus was published after a rebuild started, the child being rebuilt
was not added to writers. This caused I/Os missing the child, leading to
a corrupted replica.