fix(rebuild): add same device validation

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
openebs · Jan 30, 2024 · dc53c12 · dc53c12
1 parent 37f211c
commit dc53c12
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/io-engine/src/rebuild/rebuild_descriptor.rs b/io-engine/src/rebuild/rebuild_descriptor.rs
@@ -86,6 +86,12 @@ impl RebuildDescriptor {
             bdev: dst_uri.to_string(),
         })?;
 
+        if src_descriptor.device_name() == dst_descriptor.device_name() {
+            return Err(RebuildError::SameBdev {
+                bdev: src_descriptor.device_name(),
+            });
+        }
+
         let source_hdl = RebuildDescriptor::io_handle(&*src_descriptor).await?;
         let destination_hdl =
             RebuildDescriptor::io_handle(&*dst_descriptor).await?;

diff --git a/io-engine/src/rebuild/rebuild_error.rs b/io-engine/src/rebuild/rebuild_error.rs
@@ -15,6 +15,10 @@ pub enum RebuildError {
     NoCopyBuffer { source: DmaError },
     #[snafu(display("Failed to validate rebuild job creation parameters"))]
     InvalidParameters {},
+    #[snafu(display(
+        "The same device was specified for both source and destination: {bdev}"
+    ))]
+    SameBdev { bdev: String },
     #[snafu(display("Failed to get a handle for bdev {}", bdev))]
     NoBdevHandle { source: CoreError, bdev: String },
     #[snafu(display("Bdev {} not found", bdev))]