Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(chart): provide CRDs in a subchart #414

Commits on Mar 14, 2024

  1. refactor(chart): provide CRDs in a subchart

    This changeset is mainly intended to skip Jaeger CRDs if it is not
    enabled. This is especially relevant when Jaeger tracing is installed
    separately from OpenEBS Mayastor.
    
    Helm 3 does not manage CRDs.
    - https://helm.sh/docs/chart_best_practices/custom_resource_definitions
    
    `helm uninstall` won't remove CRDs, and `helm updgrade` won't upgrade
    them. Manual intervention is required with the current setup.
     - CRDs installed from `crds` folder are not included into the
     helm release.
    
    Additionally, it is not possible to template CRDs in Helm 3 in the
    `crds` folder.
    
    Moving CRDs to a chart solves several issues: clean uninstall,
    possibility for upgrades, templating.
    
    Also make volumeSnapshots CRD optional
    
    Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
    cmontemuino committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    451e5b6 View commit details
    Browse the repository at this point in the history
  2. fix: wrong indentation in crd values

    Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
    cmontemuino committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    31f7852 View commit details
    Browse the repository at this point in the history
  3. docs: update readme

    Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
    cmontemuino committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    92e2c38 View commit details
    Browse the repository at this point in the history