-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eventing): add supportability for nats #405
feat(eventing): add supportability for nats #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. README changes are not needed.
@datacore-vvarakantham @tiagolobocastro -- the script is adding the nats documentation because the nats dependency chart tar is unpacked in the chart/charts directory. @datacore-vvarakantham could you remove the chart/charts directory and try again. |
bffa0eb
to
f80521d
Compare
Why is this only happening now? |
I have unpacked to check some values actually. That was why it might be getting added to the README.md. |
Signed-off-by: Vandana Varakantham <vandana.varakantham@datacore.com>
f80521d
to
1a5a2e4
Compare
bors merge |
405: feat(eventing): add supportability for nats r=datacore-vvarakantham a=datacore-vvarakantham <! Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
bors merge |
Build succeeded: |
This fixes the helm-docs issue: #435. |
Added supportability for NATS service.
Description
Adding NATS pods' logs to the support bundle.
Motivation and Context
Regression
How Has This Been Tested?
Types of changes
Checklist: