Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventing): add supportability for nats #405

Conversation

datacore-vvarakantham
Copy link
Contributor

@datacore-vvarakantham datacore-vvarakantham commented Jan 17, 2024

Added supportability for NATS service.

Description

Adding NATS pods' logs to the support bundle.

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

chart/README.md Outdated Show resolved Hide resolved
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. README changes are not needed.

@niladrih
Copy link
Member

@datacore-vvarakantham @tiagolobocastro -- the script is adding the nats documentation because the nats dependency chart tar is unpacked in the chart/charts directory.

@datacore-vvarakantham could you remove the chart/charts directory and try again.

@tiagolobocastro
Copy link
Contributor

@datacore-vvarakantham @tiagolobocastro -- the script is adding the nats documentation because the nats dependency chart tar is unpacked in the chart/charts directory.

Why is this only happening now?

@datacore-vvarakantham
Copy link
Contributor Author

datacore-vvarakantham commented Jan 25, 2024

@datacore-vvarakantham @tiagolobocastro -- the script is adding the nats documentation because the nats dependency chart tar is unpacked in the chart/charts directory.

Why is this only happening now?

I have unpacked to check some values actually. That was why it might be getting added to the README.md.

@niladrih
Copy link
Member

niladrih commented Jan 25, 2024

Why is this only happening now?

If by this you're referring to the unpacking we do during the upgrade-job container build (here), then you'd want to know that I've added a cleanup for that here. Dependencies only work with the doc script, if they are left in their tarball form.

Signed-off-by: Vandana Varakantham <vandana.varakantham@datacore.com>
@datacore-vvarakantham
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 31, 2024
405: feat(eventing): add supportability for nats r=datacore-vvarakantham a=datacore-vvarakantham

<!

Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
@datacore-vvarakantham
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 37aa562 into openebs:develop Jan 31, 2024
5 checks passed
@niladrih
Copy link
Member

This fixes the helm-docs issue: #435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants