Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade-job fixes #399

Merged
merged 3 commits into from
Jan 10, 2024
Merged

fix: upgrade-job fixes #399

merged 3 commits into from
Jan 10, 2024

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Dec 24, 2023 •
edited
Loading

Changes:

  1. The localpv-provisioner helm chart was updated to v3.5.0 with the release of Mayastor v2.5.0. The yq merge would retain the release-version and image tags on the localpv helm values. They need to be manually overriden.
  2. The scrapeConfigs change is only applied if the source configuration is the older default. It should move to newer default, only if the chart had the older default to begin with. This prevents overriding user-defined custom configuration.

@niladrih niladrih changed the title Upgrade localpv fix: upgrade-job fixes Dec 24, 2023
@niladrih niladrih force-pushed the upgrade-localpv branch 4 times, most recently from 4c56541 to e74f6ca Compare December 27, 2023 14:06
@niladrih niladrih added the wip Indicates that this is a work in progress label Jan 9, 2024
@niladrih niladrih removed the wip Indicates that this is a work in progress label Jan 10, 2024
@niladrih niladrih added the DO NOT MERGE Bors-compliant label to avoid accidental merges label Jan 10, 2024
@niladrih niladrih removed the DO NOT MERGE Bors-compliant label to avoid accidental merges label Jan 10, 2024
@niladrih
fix(upgrade-job): add set-values for localpv upgrade
e5695c3 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
fix(upgrade-job): update scrapeConfigs only if source is default
e302c3f 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
feat(upgrade-job): add set-values for NDM image tags
a5e688c 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 4a85e37 into develop Jan 10, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the upgrade-localpv branch January 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@hrudaya21 hrudaya21 Awaiting requested review from hrudaya21

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

@dsharma-dc dsharma-dc Awaiting requested review from dsharma-dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niladrih @tiagolobocastro @sinhaashish