refactor(chart): provide CRDs in a subchart

This changeset is mainly intended to skip Jaeger CRDs if it is not enabled.
It is especially relevant when Jaeger tracing is installed separately from OpenEBS Mayastor.

Helm 3 does not manage CRDs (see https://helm.sh/docs/chart_best_practices/custom_resource_definitions/).
`helm uninstall` won't remove CRDs, and `helm updgrade` won't upgrade them. Manual intervention is required
with the current setup.
 - CRDs installed from `crds` folder **are not included into the helm release**.

Additionally, it is not possible to template CRDs in Helm 3 in the `crds` folder.

Moving CRDs to a chart solves several issues: clean uninstall, possibility for upgrades, templating.

close openebs/mayastor/#1586

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>

chart/Chart.yaml

@@ -25,6 +25,9 @@ version: 0.0.0
 appVersion: "0.0.0"
 
 dependencies:
+  - name: crds
+    version: "0.0.0"
+    condition: crds.enabled
   - name: etcd
     repository: https://charts.bitnami.com/bitnami
     version: 8.6.0

chart/README.md

@@ -37,13 +37,24 @@ To install the chart with the release name `my-release`:
 
 ```console
 $ helm repo add openebs https://openebs.github.io/mayastor-extensions/
-$ helm install my-release openebs/mayastor
+$ helm install mymayastor
 ```
 
+### Uninstall Helm Chart
+
+```console
+$ helm uninstall [RELEASE_NAME] 
+```
+
+This removes all the Kubernetes components associated with the chart and deletes the release.
+
+*See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command documentation.*
+
 ## Chart Dependencies
 
 | Repository | Name | Version |
 |------------|------|---------|
+|  | crds | 0.0.0 |
 | https://charts.bitnami.com/bitnami | etcd | 8.6.0 |
 | https://grafana.github.io/helm-charts | loki-stack | 2.9.11 |
 | https://jaegertracing.github.io/helm-charts | jaeger-operator | 2.25.0 |
@@ -93,6 +104,8 @@ $ helm install my-release openebs/mayastor
 | base.​jaeger.​enabled | Enable jaeger tracing | `false` |
 | base.​logSilenceLevel | Silence specific module components | `nil` |
 | base.​metrics.​enabled | Enable the metrics exporter | `true` |
+| crds.​enabled | Install CRDs | `true` |
+| crds.​jaeger.​enabled | Install Jaeger CRDs | `false` |
 | csi.​controller.​logLevel | Log level for the csi controller | `"info"` |
 | csi.​controller.​preventVolumeModeConversion | Prevent modifying the volume mode when creating a PVC from an existing VolumeSnapshot | `true` |
 | csi.​controller.​priorityClassName | Set PriorityClass, overrides global | `""` |

chart/README.md.tmpl

@@ -39,6 +39,16 @@ $ helm repo add openebs https://openebs.github.io/mayastor-extensions/
 $ helm install my-release openebs/{{ template "chart.name" . }}
 ```
 
+### Uninstall Helm Chart
+
+```console
+$ helm uninstall [RELEASE_NAME] 
+```
+
+This removes all the Kubernetes components associated with the chart and deletes the release.
+
+*See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command documentation.*
+
 ## Chart Dependencies
 
 {{ template "chart.requirementsTable" . }}

chart/crds/jaeger.yaml → chart/charts/crds/templates/jaeger.yaml

@@ -1,3 +1,4 @@
+{{- if .Values.jaeger.enabled -}}
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
@@ -42,3 +43,4 @@ spec:
       storage: true
       subresources:
         status: {}
+{{- end -}}

chart/values.yaml

@@ -1,3 +1,10 @@
+crds:
+  # -- Install CRDs
+  enabled: true
+  jaeger:
+    # -- Install Jaeger CRDs
+    enabled: false
+
 image:
   # -- Image registry to pull our product images
   registry: docker.io