Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(volume/resize): handle overflow during volume shrink attempt #784

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(volume/resize): handle overflow during volume shrink attempt #784

merged 1 commit into from
Mar 19, 2024

Conversation

dsharma-dc
Copy link
Contributor

@dsharma-dc dsharma-dc commented Mar 18, 2024 •
edited
Loading

This fixes the case where an attempt to shrink the volume with a capacity limit set on cluster - panicked with below error:

stderr:
thread 'tokio-runtime-worker' panicked at control-plane/agents/src/bin/core/volume/service.rs:611:24:
attempt to subtract with overflow
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 19, 2024
Try #784:
9169eb2
hrudaya21
hrudaya21 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@hrudaya21 hrudaya21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bors-openebs-mayastor
Copy link

try

Build succeeded:

chriswldenyer
chriswldenyer approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@chriswldenyer chriswldenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

control-plane/agents/src/bin/core/volume/service.rs Show resolved Hide resolved
@dsharma-dc
fix(volume/resize): handle overflow during volume shrink attempt
0e39475 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 1ee5592 into develop Mar 19, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the vol_shrink_fix branch March 19, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrudaya21 hrudaya21 hrudaya21 approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@chriswldenyer chriswldenyer chriswldenyer approved these changes

@tiagolobocastro tiagolobocastro Awaiting requested review from tiagolobocastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsharma-dc @hrudaya21 @Abhinandan-Purkait @chriswldenyer