fix(csi-controller/pv-watcher): race between creation and gc #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
Abhinandan-Purkait,
niladrih and
abhilashshetty04
tiagolobocastro
force-pushed
the
vol-orphan
branch
2 times, most recently
from
c0992f4
to
d89f268
Compare
Abhinandan-Purkait
approved these changes
Mar 4, 2024
niladrih
approved these changes
Mar 4, 2024
abhilashshetty04
approved these changes
Mar 4, 2024
Check for deletion candidates using PVC and when such candidate is found also ensure there is no corresponding PV. This is required to avoid a race during creation where the volume is created but the PV is not yet. Also, do this check twice, as otherwise we might find false positives when a PVC is deleted before the PV is sucessfully created, leading to confusing message about GC. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
vol-orphan
branch
2 times, most recently
from
4a4b79f
to
c307925
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for deletion candidates using PVC and when such candidate is found
also ensure there is no corresponding PV.
This is required to avoid a race during creation where the volume is created
but the PV is not yet.
Also, do this check twice, as otherwise we might find false positives when
a PVC is deleted before the PV is sucessfully created, leading to confusing
message about GC.