fix(csi-driver): support getting device size from devpath #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
Abhinandan-Purkait and
dsharma-dc
dsharma-dc
approved these changes
Mar 1, 2024
dsharma-dc
reviewed
Mar 1, 2024
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
When processing the NodeExpandVolume CSI call, we compare the sysfs size of the volume nexus against the requested capacity. Shaving 10MiB off the requested capacity puts the number in the ballpark range of the capacity we expect from the nexus after the ControllerExpandVolume has expanded it. Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
tiagolobocastro
approved these changes
Mar 1, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
765: fix(csi-driver): support getting device size from devpath r=niladrih a=niladrih Changes: - the Device::lookup() API doesn't return a dev-name, but instead returns a dev-path. Changed the size function to accept either. - the `failure!` macro prints errors event if they are never encountered, when used with the `ok_or()` combinator. Using the `ok_or_else()` combinator instead. - Adjusting the expected capacity of the nexus during NodeExpandVolume call to be at most 10MiB less than the requested capacity. Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
|
Canceled. |
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
|
bors merge |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
failure!macro prints errors event if they are never encountered, when used with theok_or()combinator. Using theok_or_else()combinator instead.