Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check cluster capacity limit during volume resize, and also allow volume resize via rest plugin #747

Merged
merged 3 commits into from
Feb 26, 2024
Merged

check cluster capacity limit during volume resize, and also allow volume resize via rest plugin #747

merged 3 commits into from
Feb 26, 2024

Conversation

dsharma-dc
Copy link
Contributor

@dsharma-dc dsharma-dc commented Feb 16, 2024 •
edited
Loading

  • Enforce cluster capacity limit checks during volume resize.
  • Allow volume resize operation via REST plugin.

@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 19, 2024
Try #747:
af3ab44
@bors-openebs-mayastor
Copy link

try

Build failed:

tiagolobocastro
tiagolobocastro approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR needs renaming as you've also added resize support to the plugin

control-plane/agents/src/bin/core/volume/specs.rs Outdated Show resolved Hide resolved
control-plane/plugin/src/resources/volume.rs Outdated Show resolved Hide resolved
@dsharma-dc dsharma-dc changed the title feat(volume/resize): enforce cluster capacity limit check during volume resize enforce cluster capacity limit check during volume resize and also allow volume resize via rest plugin Feb 22, 2024
@dsharma-dc dsharma-dc changed the title enforce cluster capacity limit check during volume resize and also allow volume resize via rest plugin check cluster capacity limit during volume resize, and also allow volume resize via rest plugin Feb 22, 2024
@dsharma-dc
Copy link
Contributor Author

Your PR needs renaming as you've also added resize support to the plugin

Done.

@dsharma-dc
feat(volume/resize): enforce cluster capacity limit check during volu…
2e0061f 
…me resize

Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
test(volume/resize): add test for concurrent cluster capacity limit c…
8dea6d2 
…hecks

Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
feat(volume/resize): add volume resize to rest plugin
5f68705 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 550e4df into openebs:develop Feb 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@niladrih niladrih Awaiting requested review from niladrih

@hrudaya21 hrudaya21 Awaiting requested review from hrudaya21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsharma-dc @tiagolobocastro @Abhinandan-Purkait