Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add json formatting support #745

Merged
merged 1 commit into from
Mar 1, 2024
Merged

add json formatting support #745

merged 1 commit into from
Mar 1, 2024

Conversation

abhilashshetty04
Copy link
Contributor

No description provided.

Abhinandan-Purkait
Abhinandan-Purkait reviewed Feb 16, 2024
View reviewed changes
control-plane/agents/src/bin/core/main.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/controller/main.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/node/main_.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/ha/node/main.rs Outdated Show resolved Hide resolved
control-plane/rest/service/src/main.rs Outdated Show resolved Hide resolved
Abhinandan-Purkait
Abhinandan-Purkait approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiagolobocastro
tiagolobocastro reviewed Feb 21, 2024
View reviewed changes
control-plane/agents/src/bin/core/main.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/core/main.rs Outdated Show resolved Hide resolved
control-plane/agents/src/bin/ha/cluster/main.rs Outdated Show resolved Hide resolved
control-plane/csi-driver/src/bin/controller/main.rs Show resolved Hide resolved
utils/utils-lib/src/tracing_telemetry.rs Outdated Show resolved Hide resolved
utils/utils-lib/src/tracing_telemetry.rs Outdated Show resolved Hide resolved
utils/utils-lib/src/tracing_telemetry.rs Outdated Show resolved Hide resolved
utils/utils-lib/src/tracing_telemetry.rs Outdated Show resolved Hide resolved
utils/utils-lib/src/tracing_telemetry.rs Outdated Show resolved Hide resolved
utils/utils-lib/src/tracing_telemetry.rs Outdated Show resolved Hide resolved
tiagolobocastro
tiagolobocastro approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits

utils/utils-lib/src/tracing_telemetry.rs Show resolved Hide resolved
@abhilashshetty04
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 26, 2024
@abhilashshetty04
chore(bors): merge pull request #745
7471c63 
745: add json formatting support r=abhilashshetty04 a=abhilashshetty04



Co-authored-by: Abhilash Shetty <abhilash.shetty@datacore.com>
@bors-openebs-mayastor
Copy link

Build failed:

@abhilashshetty04
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 26, 2024
@abhilashshetty04
chore(bors): merge pull request #745
d5995a6 
745: add json formatting support r=abhilashshetty04 a=abhilashshetty04



Co-authored-by: Abhilash Shetty <abhilash.shetty@datacore.com>
@bors-openebs-mayastor
Copy link

Build failed:

@abhilashshetty04
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 26, 2024
@abhilashshetty04
chore(bors): merge pull request #745
fd1704b 
745: add json formatting support r=abhilashshetty04 a=abhilashshetty04



Co-authored-by: Abhilash Shetty <abhilash.shetty@datacore.com>
@bors-openebs-mayastor
Copy link

Build failed:

@abhilashshetty04
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 27, 2024
Try #745:
ce68c2a
@bors-openebs-mayastor
Copy link

try

Build failed:

@abhilashshetty04
feat(fmt_style): enabling fmt style selection
0eb55a5 
Signed-off-by: Abhilash Shetty <abhilash.shetty@datacore.com>
@abhilashshetty04
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 1, 2024
Try #745:
6e269c6
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@abhilashshetty04
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit f485d18 into develop Mar 1, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the json_stdout branch March 1, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@datacore-vvarakantham datacore-vvarakantham Awaiting requested review from datacore-vvarakantham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhilashshetty04 @tiagolobocastro @Abhinandan-Purkait