Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use pagination to load values from pstor #737

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Abhinandan-Purkait
Copy link
Member

Changes in the PR.

  • Changes the spec population from etcd from non paged call to a paged call.
  • Also incorporates the pagination to legacy migration flows.

@Abhinandan-Purkait
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 12, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@Abhinandan-Purkait
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 12, 2024
@bors-openebs-mayastor
Copy link

try

Build failed:

utils/pstor/src/etcd.rs Outdated Show resolved Hide resolved
utils/pstor/src/etcd.rs Outdated Show resolved Hide resolved
utils/pstor/src/etcd.rs Show resolved Hide resolved
@Abhinandan-Purkait
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 13, 2024
@bors-openebs-mayastor
Copy link

try

Build failed:

@Abhinandan-Purkait
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 13, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@Abhinandan-Purkait
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 13, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit df513c1 into release/2.5 Feb 13, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the pstor_pagination branch February 13, 2024 13:00
bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 21, 2024
753: cherry-pick: #737 to use pstor pagination r=Abhinandan-Purkait a=Abhinandan-Purkait

### Changes in the PR.

- Changes the spec population from etcd from non paged call to a paged call.
- Also incorporates the pagination to legacy migration flows.

Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants