Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pstor): when lease is lost exit instead of panic #732

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix(pstor): when lease is lost exit instead of panic #732

merged 1 commit into from
Feb 1, 2024

Conversation

tiagolobocastro
Copy link
Contributor

Avoids generating coredumps, as it won't add anything useful here.

@tiagolobocastro
fix(pstor): when lease is lost exit instead of panic
9d59b06 
Avoids generating coredumps, as it won't add anything useful here.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Feb 1, 2024
@tiagolobocastro
chore(bors): merge pull request #732
f6479db 
732: fix(pstor): when lease is lost exit instead of panic r=tiagolobocastro a=tiagolobocastro

Avoids generating coredumps, as it won't add anything useful here.

Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
@bors-openebs-mayastor
Copy link

Build failed:

@tiagolobocastro
Copy link
Contributor Author

@dsharma-dc PTAL at the expand bdd failure above
bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 182f9e3 into develop Feb 1, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the lease-panic branch February 1, 2024 16:33
@dsharma-dc
Copy link
Contributor

dsharma-dc commented Feb 1, 2024 •
edited
Loading

@dsharma-dc PTAL at the expand bdd failure above bors merge

hmm, looks like there is still some unreliability in test while waiting for faulted child. Will check.

 faulted = list(filter(lambda child: child.get("state") == "Faulted", childlist))
>       assert len(faulted) == 1, "Failed to find 1 Faulted child!"
E       AssertionError: Failed to find 1 Faulted child!
E       assert 0 == 1
E        +  where 0 = len([])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchandra19 pchandra19 pchandra19 approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

@niladrih niladrih Awaiting requested review from niladrih

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagolobocastro @dsharma-dc @pchandra19