feat(app node): register csi nodes to control plane #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
force-pushed
the
csi_registration
branch
5 times, most recently
from
a7422ae
to
5271996
Compare
Abhinandan-Purkait
force-pushed
the
csi_registration
branch
3 times, most recently
from
3ffbefb
to
6aca045
Compare
tiagolobocastro
approved these changes
Feb 7, 2024
Abhinandan-Purkait
force-pushed
the
csi_registration
branch
2 times, most recently
from
647b4bd
to
521ad39
Compare
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
Abhinandan-Purkait
force-pushed
the
csi_registration
branch
from
66d2d41
to
5ee1523
Compare
|
bors try |
tryBuild succeeded: |
Abhinandan-Purkait
force-pushed
the
csi_registration
branch
from
5ee1523
to
e6ca240
Compare
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
… tokio join instead of select Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Abhinandan-Purkait
force-pushed
the
csi_registration
branch
from
e6ca240
to
301a0fb
Compare
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor-extensions
that referenced
this pull request
Feb 13, 2024
415: feat(app node): update csi node with latests args to enable registration r=Abhinandan-Purkait a=Abhinandan-Purkait ### Changes in this PR 1. Adds the `dnsPolicy: ClusterFirstWithHostNet` so that endpoints are discoverable by dns name. 2. Adds the args to specify rest-api endpoint and enabled registration. ### Why are the changes needed? 1. These changes are needed because csi node now should register itself as an app node to the control-plane. 2. This app node info would be used in snapshot creation to issue FIFREEZE and FITHAW to the filesystem for consistency if enabled. Related Control Plane PR --> openebs/mayastor-control-plane#730 Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Node: Represents a CSI node or a node where io app/initiator would be situated.
Changes in this PR:
- This adds the registration logic for csi-node to control-plane via rest api.
- This csi-node info would be used to issue FIFREEZE and FITHAW via csi-controller.
- Moves the rest api client to the common csi-driver library to be used by both csi-controller and csi-node.