Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node labelling UX #726

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Node labelling UX #726

merged 7 commits into from
Jan 30, 2024

Commits on Jan 27, 2024

  1. build(openapi-generator): upgrade to v6.4.0 

    Namely fixes a bug related to path parsing with '='

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    5124102 View commit details
    Browse the repository at this point in the history

  2. docs(node-label/rest-plugin): improve ux for the command line 

    Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    6c2fee5 View commit details
    Browse the repository at this point in the history

  3. refactor(node-label): use specific types for store operations 

    PStor operations should use a specific type to allow for better expansion.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    c272e46 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. refactor(node-label/api): doc the cli and openapi with key val 

    Expands the parsing of label on the cli and returns different error messages.
Splits the label into key and value.
todo: is this the right approach here, where should we do the validation?
kubectl seems to some validation, is there anything on the apiserver too?

Included a bunch of formatting changes due to bad formatted code being
checked in...
todo: run python linter on CI

Updates openapi once again to get some ql error helpers.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    402a6ca View commit details
    Browse the repository at this point in the history

  2. ci: don't install pre-commit on CI 

    Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    613e951 View commit details
    Browse the repository at this point in the history

  3. ci: check if python linter modified files 

    Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    47efecf View commit details
    Browse the repository at this point in the history

  4. refactor: apply python linter suggestions 

    Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
    @tiagolobocastro
    tiagolobocastro committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    5ee2ba4 View commit details
    Browse the repository at this point in the history