Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Orphaned Volumes on a timer #724

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Delete Orphaned Volumes on a timer #724

merged 4 commits into from
Jan 24, 2024

Conversation

tiagolobocastro
Copy link
Contributor

@tiagolobocastro tiagolobocastro commented Jan 23, 2024 •
edited
Loading 

fix(csi-controller/gc): list volumes with pagination

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

chore: correct typo in the plaftform code

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

refactor(csi-controller/gc): reduce excessive unwrap and nesting

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

feat(csi-controller/orphaned-vols): gc orphaned volumes on a timer

Due to a k8s bug, when pv deletion is attempted before pvc deletion, we may not
receive the delete request, and thus leaking volumes, which cannot be deleted
through any user facing api.

Existing code to clean up orphaned volumes was being made use for the case when
certain pv events might be missed.
Therefore current WA is to delete the csi-controller pod.
This change makes use of this existing logic but runs it on a given time period
which is by default 5 minutes, which  allows us to automatically WA the bug.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

@tiagolobocastro
Copy link
Contributor Author

Resolves openebs/mayastor#1269

@tiagolobocastro
feat(csi-controller/orphaned-vols): gc orphaned volumes on a timer
ada7be5 
Due to a k8s bug, when pv deletion is attempted before pvc deletion, we may not
receive the delete request, and thus leaking volumes, which cannot be deleted
through any user facing api.

Existing code to clean up orphaned volumes was being made use for the case when
certain pv events might be missed.
Therefore current WA is to delete the csi-controller pod.
This change makes use of this existing logic but runs it on a given time period
which is by default 5 minutes, which  allows us to automatically WA the bug.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
refactor(csi-controller/gc): reduce excessive unwrap and nesting
8af25cf 
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
chore: correct typo in the plaftform code
4576447 
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
fix(csi-controller/gc): list volumes with pagination
e4a5f56 
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 3ea84a8 into develop Jan 24, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the orphaned-vols branch January 24, 2024 16:48
This was referenced Jan 24, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@niladrih niladrih Awaiting requested review from niladrih

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagolobocastro @Abhinandan-Purkait