refactor(rest-plugin): make it more modular #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih,
datacore-vvarakantham and
abhilashshetty04
Adds common cli args to the library, which the binary then makes use of. Tidies up the error scenario with common error handling and implicit trace flushing. todo: add multiple execution handlers for all subcommands as this will allow having different handlers in the external kubectl-plugin crate. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
rest-plugin
branch
from
d404e3c
to
0c79316
Compare
Allows for tidier composition of operations, which will be especially useful to reduce code duplication in kubectl plugin. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
rest-plugin
branch
from
4033d17
to
abf8348
Compare
Abhinandan-Purkait
approved these changes
Jan 23, 2024
tiagolobocastro
changed the title
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds common cli args to the library, which the binary then makes use of.
Tidies up the error scenario with common error handling and implicit trace flushing.
Add execute trait to allow for tidier composition of operations, which will be especially
useful to reduce code duplication in the kubectl plugin.