Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capacity limit for volumes #710

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

chriswldenyer
Copy link
Contributor

@chriswldenyer chriswldenyer commented Jan 5, 2024

Add mechanism for limiting the total volume size on the system by rejecting gRPC volume creation requests.

@chriswldenyer chriswldenyer force-pushed the volume-capacity-limit branch 3 times, most recently from 3b87c14 to 2c1cbcb Compare January 5, 2024 16:28
@chriswldenyer chriswldenyer force-pushed the volume-capacity-limit branch 2 times, most recently from 77afd36 to 06643fb Compare January 8, 2024 16:19
control-plane/agents/src/bin/core/volume/specs.rs Outdated Show resolved Hide resolved
control-plane/agents/src/common/errors.rs Outdated Show resolved Hide resolved
control-plane/agents/src/common/errors.rs Outdated Show resolved Hide resolved
tests/bdd/features/volume/capacity_limit/creation.feature Outdated Show resolved Hide resolved
tests/bdd/features/volume/capacity_limit/creation.feature Outdated Show resolved Hide resolved
tests/bdd/features/volume/capacity_limit/creation.feature Outdated Show resolved Hide resolved
tests/bdd/features/volume/capacity_limit/creation.feature Outdated Show resolved Hide resolved
tests/bdd/features/volume/capacity_limit/creation.feature Outdated Show resolved Hide resolved
@chriswldenyer chriswldenyer force-pushed the volume-capacity-limit branch 2 times, most recently from 46137b5 to ca5da39 Compare January 9, 2024 07:21
@chriswldenyer chriswldenyer force-pushed the volume-capacity-limit branch 3 times, most recently from bffd061 to 8b46715 Compare January 12, 2024 10:39
@chriswldenyer chriswldenyer marked this pull request as ready for review January 12, 2024 10:42
@chriswldenyer
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 12, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include a create_volume test for this

control-plane/agents/src/bin/core/volume/specs.rs Outdated Show resolved Hide resolved
control-plane/agents/src/common/errors.rs Outdated Show resolved Hide resolved
control-plane/grpc/src/operations/volume/traits.rs Outdated Show resolved Hide resolved
control-plane/stor-port/src/types/mod.rs Outdated Show resolved Hide resolved
@chriswldenyer
Copy link
Contributor Author

Let's include a create_volume test for this

working on that next

@chriswldenyer chriswldenyer force-pushed the volume-capacity-limit branch 2 times, most recently from 5600e28 to 2b4fa8a Compare January 17, 2024 14:55
@chriswldenyer
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 17, 2024
@chriswldenyer
Copy link
Contributor Author

working on that next

now added

@bors-openebs-mayastor
Copy link

try

Build succeeded:

@chriswldenyer
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 18, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

Add mechanism for limiting the total volume size on the system
by rejecting volume creation requests from REST.
Added rust unit test.

Signed-off-by: chriswldenyer <christopher.denyer@mayadata.io>
@chriswldenyer
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 19, 2024
710: feat: capacity limit for volumes r=chriswldenyer a=chriswldenyer

Add mechanism for limiting the total volume size on the system by rejecting gRPC volume creation requests.

Co-authored-by: chriswldenyer <christopher.denyer@mayadata.io>
@bors-openebs-mayastor
Copy link

Build failed:

@chriswldenyer
Copy link
Contributor Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 19, 2024
710: feat: capacity limit for volumes r=chriswldenyer a=chriswldenyer

Add mechanism for limiting the total volume size on the system by rejecting gRPC volume creation requests.

Co-authored-by: chriswldenyer <christopher.denyer@mayadata.io>
@bors-openebs-mayastor
Copy link

Build failed:

@chriswldenyer
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 2c3c789 into develop Jan 19, 2024
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the volume-capacity-limit branch January 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants