Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apiGroups in aggregate roles on manifests #402

Merged

Conversation

israel-hdez
Copy link

Cherry-pick of #401

One of the aggregate roles were using `kubeflow.org` in the API groups, which is incorrect.

This fixes the manifests to use the right API group.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1c5fb34 into opendatahub-io:release-v0.12.1 Aug 26, 2024
18 checks passed
@israel-hdez israel-hdez deleted the j11007-cp-fix branch August 28, 2024 20:15
spolti pushed a commit to spolti/kserve that referenced this pull request Sep 16, 2024
…lux/component-updates/kserve-agent-211

Update kserve-agent-211 to d3ad050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants