fix insert inode fail when load deleting partition #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cw123
force-pushed
the
fix_deleting_partition_insert_inode_fail
branch
2 times, most recently
from
04a3483
to
e725958
Compare
xu-chaojie
approved these changes
Jan 17, 2022
xu-chaojie
reviewed
Jan 17, 2022
| if (rc != MetaStatusCode::OK) { | ||
| LOG(ERROR) << "InsertInode failed, retCode = " << rc; | ||
| LOG(ERROR) << "InsertInode failed, retCode = " |
There was a problem hiding this comment.
using “：” instead of “=” in log
wu-hanqing
reviewed
Jan 17, 2022
| @@ -137,6 +130,20 @@ bool MetaStoreImpl::Load(const std::string& pathname) { | |||
| partitionMap_.clear(); | |||
| LOG(ERROR) << "Load metadata failed."; | |||
| } | |||
|
|
|||
| for (auto it = partitionMap_.begin(); it != partitionMap_.end(); it++) { | |||
There was a problem hiding this comment.
use range-based for loop
There was a problem hiding this comment.
The two methods are equivalent
cw123
force-pushed
the
fix_deleting_partition_insert_inode_fail
branch
from
e725958
to
63f8fd3
Compare
done, add test case |
wu-hanqing
approved these changes
Jan 17, 2022
| @@ -94,7 +94,10 @@ class MetastoreTest : public ::testing::Test { | |||
| first.partitionid() == second.partitionid() && | |||
| first.start() == second.start() && | |||
| first.end() == second.end() && | |||
| first.nextid() == second.nextid(); | |||
| first.nextid() == second.nextid() && | |||
There was a problem hiding this comment.
you can use google::protobuf::util::MessageDifferencer::Equals to simplify this compare
|
recheck |
2 similar comments
|
recheck |
|
recheck |
cw123
force-pushed
the
fix_deleting_partition_insert_inode_fail
branch
from
63f8fd3
to
d083c59
Compare
This was referenced Jan 18, 2022
This was
linked to
issues
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #995
Problem Summary: fix insert inode fail when load deleting partition
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List