curvefs: support replace a server which doesn't work anymore. #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
wu-hanqing
reviewed
Jan 10, 2022
| @@ -38,7 +38,7 @@ enum TopoStatusCode { | |||
| TOPO_IP_PORT_DUPLICATED = 14; | |||
| TOPO_NAME_DUPLICATED = 15; | |||
| TOPO_CREATE_COPYSET_ON_METASERVER_FAIL = 16; | |||
| TOPO_CANNOT_REMOVE_NOT_RETIRED = 17; | |||
| TOPO_CANNOT_REMOVE_NOT_OFFLINE = 17; | |||
There was a problem hiding this comment.
do we have RETIRED state for metaserver now?
There was a problem hiding this comment.
do we have
RETIREDstate for metaserver now?
Metaserver does't have this state.
Comment on lines
136
to
138
| int ClearPool(); | ||
| int ClearZone(); | ||
| int ClearServer(); |
There was a problem hiding this comment.
Clearis miss leading
fix
|
|
||
| brpc::Controller cntl; | ||
| cntl.set_timeout_ms(FLAGS_rpcTimeoutMs); | ||
| cntl.set_log_id(1); |
There was a problem hiding this comment.
if you don't want to use log_id to trace RPC calls, there's no need to set it. otherwise, you have to set a different ID for each RPC call.
There was a problem hiding this comment.
if you don't want to use
log_idto trace RPC calls, there's no need to set it. otherwise, you have to set a different ID for each RPC call.
fix
If a server with some metaservers on it, and it crashed. Then will need add a new server into the cluster.
aspirer
changed the title
|
Please associate the pull request with an issue. |
SeanHai
changed the title
wu-hanqing
approved these changes
Jan 11, 2022
SeanHai
changed the title
|
LGTM! |
Wine93
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server with some metaservers on it, and it crashed. Then will need
add a new server into the cluster.
What problem does this PR solve?
Issue Number: close #xxx
#939
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List