support wal covered writing #92

bai-charisu · 2020-09-15T08:35:50Z

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

Relevant documentation/comments is changed or added
I acknowledge that all my contributions will be made under the project's license

ilixiaocui · 2020-09-22T02:57:33Z

curve-ansible/deploy_chunkserver.yml

@@ -0,0 +1,17 @@
+
+- name: prepare chunkserver


为啥在这里有一个单独的deploy_chunkserver.yml? 之前不是直接放在deploy_curve.yml里的？

自己写的临时程序忘删了，已删掉

ilixiaocui · 2020-09-22T02:59:16Z

curve-ansible/roles/install_package/tasks/include/copy_file_to_remote.yml

    - name: copy files to tempory directory
      become: false
      copy: src={{ local_file_path }} dest={{ tmp_dir }} mode={{ file_mode }}
    - name: mv file
      shell: sudo cp -rf {{ tmp_dir }}/* {{ remote_dir_name }}
-  when: copy_file_res.failed
+  when: copy_file_res.failedss


ilixiaocui · 2020-09-22T03:32:54Z

curve-ansible/roles/install_package/templates/chunkserver_ctl.sh.j2

-    echo "                                          -chunkfilepool_dir=/data/chunkserver{id}/chunkfilepool/"
-    echo "                                          -chunkfilepool_metapath==/data/chunkserver{id}/chunkfilepool.meta"
+    echo "    deploy all wal pool                 : ./chunkserver_ctl.sh deploy-wal-pool all"
+    echo "    deploy one wal pool                 : ./chunkserver_ctl.sh deploy-wal-pool {\$chunkserverId}"


没有deploy all chunkfile pool 和 deploy one chunkfilepool吗

目前没有场景需要提供单独的格式化chunfile pool的命令

ilixiaocui · 2020-09-22T06:03:28Z

src/chunkserver/chunk_closure.h

@@ -46,6 +46,7 @@ class ChunkClosure : public braft::Closure {
    ~ChunkClosure() = default;

    void Run() override;
+    butil::Timer timer;



加在下面成员变量中

这个是用来计算metric的，不再需要，已去掉

ilixiaocui · 2020-09-22T06:12:57Z

deploy/local/chunkserver/conf/chunkserver.conf.0

+walfilepool.meta_path=./0/walfilepool.meta
+walfilepool.segment_size=8388608
+walfilepool.metapage_size=4096
+walfilepool.meta_file_size=4096


meta_file_size 和 metapage_size 有啥区别

meta_file_size是记录元数据文件的大小，元数据文件是格式化之后存放pool的目录，file_size，meta_size这些元数据的。
metapage_size是头部的meta page的大小，也是内存对齐的单位

ilixiaocui · 2020-09-22T06:22:51Z

src/chunkserver/op_request.cpp

@@ -35,6 +35,9 @@
 #include "src/chunkserver/clone_manager.h"
 #include "src/chunkserver/clone_task.h"

+static bvar::LatencyRecorder g_oprequest_writechunk_latency(


临时的metric先去掉吧，后面统一添加，需要有开关

ilixiaocui · 2020-09-22T07:01:22Z

src/chunkserver/raftlog/curve_segment.h

+        return _from_pool;
+    }
+ private:
+friend class butil::RefCountedThreadSafe<CurveSegment>;


ilixiaocui · 2020-09-22T08:21:19Z

src/fs/ext4_filesystem_impl.cpp


 #include "src/common/string_util.h"
 #include "src/fs/ext4_filesystem_impl.h"
 #include "src/fs/wrap_posix.h"

 #define MIN_KERNEL_VERSION KERNEL_VERSION(3, 15, 0)
+static bvar::LatencyRecorder g_fs_write_latency(


临时的metric先去掉吧

deploy/local/chunkserver/conf/chunkserver.conf.0

src/chunkserver/raftlog/curve_segment_log_storage.cpp

src/chunkserver/raftlog/define.h

src/chunkserver/raftlog/curve_segment.cpp

src/chunkserver/raftlog/curve_segment.h

src/chunkserver/raftlog/curve_segment.cpp

ilixiaocui · 2020-09-24T07:21:45Z

src/chunkserver/raftlog/curve_segment_log_storage.cpp

+        do {
+            if (dynamic_cast<BraftSegment *>(_open_segment.get()) != nullptr) {
+                LOG(INFO) << "Loaded a braft open segment, close it directly";
+                scoped_refptr<Segment> prev_open_segment;


这里为啥要使用scoped_refptr

braft::segment是用scoped_refptr管理的，把析构函数定义成了私有的，只有scope ptr能够访问

ilixiaocui · 2020-09-24T07:53:01Z

src/chunkserver/raftlog/curve_segment_log_storage.cpp

+    if (first_index == last_index + 1) {
+        return -1;
+    }
+    if (index < first_index || index > last_index + 1) {


为啥不是index > last_index?

这个是为了把index=last_index+1单独处理，不打日志。replicator复制日志的时候会逐渐增加index去get_entry，直到即将发送的entry数量超过最大值或者get_entry返回失败。所以index=last_index+1是每次循环结束的条件，不用打日志。

ilixiaocui · 2020-09-24T07:58:40Z

src/chunkserver/raftlog/curve_segment_log_storage.cpp

+            << " first_log_index: " << first_index
+            << " last_log_index: " << last_index;
+        return -1;
+    } else if (index == last_index + 1) {


为什么这个要放在这里单独判断

bai-charisu force-pushed the master branch 8 times, most recently from edebdd3 to a2273ab Compare September 18, 2020 08:25

bai-charisu closed this Sep 18, 2020

bai-charisu reopened this Sep 18, 2020

bai-charisu force-pushed the master branch 5 times, most recently from 4be12d7 to d3228ef Compare September 18, 2020 14:28

bai-charisu closed this Sep 18, 2020

bai-charisu reopened this Sep 18, 2020

bai-charisu force-pushed the master branch 3 times, most recently from 66964ff to 3fe5496 Compare September 21, 2020 07:38

bai-charisu closed this Sep 21, 2020

bai-charisu reopened this Sep 21, 2020

ilixiaocui reviewed Sep 22, 2020

View reviewed changes

bai-charisu force-pushed the master branch 4 times, most recently from 9b3fec6 to 53b124e Compare September 23, 2020 07:43

xu-chaojie requested changes Sep 23, 2020

View reviewed changes

bai-charisu force-pushed the master branch 2 times, most recently from 288d697 to 3ae488e Compare September 24, 2020 06:41

ilixiaocui reviewed Sep 24, 2020

View reviewed changes

bai-charisu added 2 commits September 24, 2020 16:38

fix check_chunkserver and check_mds

998c546

add curve segment storage

9b54ee1

bai-charisu force-pushed the master branch from f6421a4 to 9b54ee1 Compare September 24, 2020 08:39

xu-chaojie approved these changes Sep 24, 2020

View reviewed changes

xu-chaojie merged commit 5d648c9 into opencurve:master Sep 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support wal covered writing #92

support wal covered writing #92

bai-charisu commented Sep 15, 2020

ilixiaocui Sep 22, 2020

bai-charisu Sep 23, 2020

ilixiaocui Sep 22, 2020

bai-charisu Sep 23, 2020

ilixiaocui Sep 22, 2020

bai-charisu Sep 23, 2020

ilixiaocui Sep 22, 2020

bai-charisu Sep 23, 2020

ilixiaocui Sep 22, 2020

bai-charisu Sep 23, 2020

ilixiaocui Sep 22, 2020 •

edited

Loading

bai-charisu Sep 23, 2020

ilixiaocui Sep 22, 2020

bai-charisu Sep 23, 2020

ilixiaocui Sep 22, 2020

bai-charisu Sep 23, 2020

ilixiaocui Sep 24, 2020

bai-charisu Sep 24, 2020

ilixiaocui Sep 24, 2020

bai-charisu Sep 24, 2020

ilixiaocui Sep 24, 2020

support wal covered writing #92

support wal covered writing #92

Conversation

bai-charisu commented Sep 15, 2020

What problem does this PR solve?

What is changed and how it works?

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilixiaocui Sep 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilixiaocui Sep 22, 2020 •

edited

Loading