scripts: fix potential overflow when cnovert ip to value #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wine93
reviewed
Jul 22, 2021
| @@ -21,6 +21,18 @@ daemonLog=${logPath}/curve-mds-daemon.log | |||
| # console output | |||
| consoleLog=${logPath}/curve-mds-console.log | |||
|
|
|||
| function ip_value() { | |||
| ip=$(echo $1 | awk -F':' '{ printf $1 }') | |||
There was a problem hiding this comment.
Maybe the function can be more simple:
echo $1 | awk -F '[:/.]' '{
mask = (2 ** 8)
print (($1 * mask + $2) * mask + $3) * mask + $4
}'
wu-hanqing
force-pushed
the
scripts/fix-ip-calc-overflow
branch
from
4cda478
to
6ba0a3c
Compare
SeanHai
approved these changes
Jul 23, 2021
wu-hanqing
force-pushed
the
scripts/fix-ip-calc-overflow
branch
from
6ba0a3c
to
7af8a32
Compare
Wine93
approved these changes
Jul 23, 2021
ilixiaocui
approved these changes
Jul 28, 2021
2 tasks
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
Add KubeEdge to LFX Mentorship Q1-2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List