client: explicit stop LeaseExecutor in FileInstance::UnInitialize #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hanqing
force-pushed
the
fix/leaseexecutor
branch
2 times, most recently
from
589c56d
to
5edc463
Compare
ilixiaocui
reviewed
Jun 23, 2021
test/client/lease_executor_test.cpp
Outdated
|
|
||
| std::this_thread::sleep_for(std::chrono::seconds(10)); | ||
|
|
||
| // does not explicit call exec.Stop() |
There was a problem hiding this comment.
annotations here are used for explanation
SeanHai
approved these changes
Jun 23, 2021
wu-hanqing
force-pushed
the
fix/leaseexecutor
branch
from
5edc463
to
6909750
Compare
|
recheck |
1 similar comment
|
recheck |
When uninit FileClient and some files are not closed, in FileInstance's destructor it will destroy LeaseExecutor, but LeaseExecutor's destructor will wait for backend lease task to stop, so without explicit close a file, thread will be stuck here. Signed-off-by: wuhanqing <wuhanqing@hotmail.com>
wu-hanqing
force-pushed
the
fix/leaseexecutor
branch
from
6909750
to
2c18139
Compare
ilixiaocui
approved these changes
Jun 28, 2021
|
recheck |
2 tasks
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
Add project proposal for GSoD 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When uninit FileClient and some files are not closed, in FileInstance's destructor it will destroy LeaseExecutor, but LeaseExecutor's destructor will wait for backend lease task to stop, so without explicit close a file, thread will be stuck here.
What is changed and how it works?
What's Changed:
Explicit call
LeaseExecutor::StopinFileInstance::UnInitializeSide effects(Breaking backward compatibility? Performance regression?):
No
Check List