chunkserver: do not init and expose walpool when not use curve protoc… #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cw123
reviewed
Mar 15, 2021
| std::string raftLogUri; | ||
| LOG_IF(FATAL, !conf.GetStringValue("copyset.raft_log_uri", &raftLogUri)); | ||
| std::string raftLogProtocol = UriParser::GetProtocolFromUri(raftLogUri); | ||
| bool useChunkFilePoolAsWalPool = true; |
There was a problem hiding this comment.
what is useChunkFilePoolAsWalPool mean?
There was a problem hiding this comment.
use chunkfile pool as wal pool
ilixiaocui
reviewed
Mar 16, 2021
| FilePoolOptions walFilePoolOptions; | ||
| InitWalFilePoolOptions(&conf, &walFilePoolOptions); | ||
| kWalFilePool = std::make_shared<FilePool>(fs); | ||
| LOG_IF(FATAL, false == kWalFilePool->Initialize(walFilePoolOptions)) |
There was a problem hiding this comment.
outputs info log if succeeds
cw123
approved these changes
Mar 16, 2021
ilixiaocui
approved these changes
Mar 16, 2021
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ol in raftLogUri
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List