nbd: unmap wait process exit #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bai-charisu
approved these changes
Jan 20, 2021
xu-chaojie
reviewed
Jan 20, 2021
nbd/src/NBDTool.cpp
Outdated
| return 0; | ||
| } | ||
|
|
||
| // TODO(wuhanqing): make this to NBDConfig |
There was a problem hiding this comment.
这个TODO处理掉吧，没必要留着，考虑下需不需要加到配置里去，如果不需要，就单独一个常量定义就可以了，如果需要就增加到配置里吧
nbd/src/NBDTool.cpp
Outdated
| return ret; | ||
| } | ||
|
|
||
| ret = WaitForTerminate(devpath, devpid, 5000); |
There was a problem hiding this comment.
这个5000也考虑下是否需要加到配置中，或者定义成常量，不要用裸的数字。
wu-hanqing
force-pushed
the
fix/nbd-wait-exit
branch
from
f4bc7c2
to
7baa919
Compare
xu-chaojie
approved these changes
Jan 20, 2021
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
CommunityBridge selected SMI project and mentee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List