fix atomic bug of FilePool::GetFile() #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinyihust
changed the title
qinyihust
changed the title
qinyihust
changed the title
xu-chaojie
approved these changes
Dec 25, 2020
xu-chaojie
reviewed
Dec 25, 2020
| currentmaxfilenum_.fetch_add(1); | ||
| srcpath = currentdir_ + "/" + std::to_string(currentmaxfilenum_); | ||
| srcpath = currentdir_ + "/" + | ||
| std::to_string(currentmaxfilenum_.fetch_add(1)); |
There was a problem hiding this comment.
这个地方改变了原来的意义，原来取的是加1的值，你这里取的是前一个值，有风险
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
Added last Thanos project for Community Bridge. 🤗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
In MDSExceptionTest
two thread running FilePool::GetFile (getFileFromPool=false) get the same filename, and write concurrently, one of them failed in rename operation:
I 2020-12-23T15:03:40.595710+0800 2375935 file_pool.cpp:289] src path = ./moduleException1/chunkfilepool//268, dist path = ./moduleException1/copysets/4294967574/log/curve_log_inprogress_00000000000000000001
I 2020-12-23T15:03:40.595726+0800 2375978 copyset_node.cpp:434] Copyset: (1, 274, 4294967570), peer id: 127.0.0.1:22225:0 become leader, term is: 2
I 2020-12-23T15:03:40.595696+0800 2375911 file_pool.cpp:289] src path = ./moduleException1/chunkfilepool//268, dist path = ./moduleException1/copysets/4294967572/log/curve_log_inprogress_00000000000000000001
I 2020-12-23T15:03:40.609778+0800 2375935 file_pool.cpp:310] get file success! now pool size = 0
……
I 2020-12-23T15:03:40.609822+0800 2375935 curve_segment.cpp:89] Created new segment `./moduleException1/copysets/4294967574/log/curve_log_inprogress_00000000000000000001' with fd=560
W 2020-12-23T15:03:40.609853+0800 2375911 ext4_filesystem_impl.cpp:240] rename failed: No such file or directory. old path: ./moduleException1/chunkfilepool//268, new path: ./moduleException1/copysets/4294967572/log/curve_log_inprogress_00000000000000000001, flag: 1
E 2020-12-23T15:03:40.609890+0800 2375911 file_pool.cpp:308] file rename failed, ./moduleException1/chunkfilepool//268
What is changed and how it works?
What's Changed:
old code:
currentmaxfilenum_.fetch_add(1)
srcpath = currentdir_ + "/" + std::to_string(currentmaxfilenum_);
new code:
srcpath = currentdir_ + "/" + std::to_string(currentmaxfilenum_.fetch_add(1));
btw, additional file pool test case is provided.