tool support copyset snapshot #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bai-charisu
force-pushed
the
tool-snapshot
branch
from
324ba59
to
e8668b6
Compare
wu-hanqing
reviewed
Dec 16, 2020
| @@ -1383,6 +1405,28 @@ void TopologyServiceManager::GetCopySetsInCluster( | |||
| CopysetInfo *info = response->add_copysetinfos(); | |||
| info->set_logicalpoolid(copyset.first); | |||
| info->set_copysetid(copyset.second); | |||
| if (request->getcsloc()) { | |||
There was a problem hiding this comment.
这部分代码和上面的是不是一样的？如果是一样的，最好封装一下。
There was a problem hiding this comment.
这一段逻辑去掉了，改为在chunkserver里面增加打全部快照的接口
ilixiaocui
reviewed
Dec 18, 2020
proto/topology.proto
Outdated
| @@ -415,13 +415,15 @@ message GetChunkServerListInCopySetsResponse { | |||
| message CopysetInfo { | |||
| required uint32 logicalPoolId = 1; | |||
| required uint32 copysetId = 2; | |||
| repeated ChunkServerLocation csLocs = 3; | |||
There was a problem hiding this comment.
这里直接发两次rpc，一次获取copsetInfo, 一次获取chunkserverIno就行？
| opt.timeout_ms = FLAGS_timeout_ms; | ||
| opt.max_retry = FLAGS_max_retry; | ||
| butil::Status st = curve::chunkserver::Snapshot( | ||
| FLAGS_logicalPoolId, |
There was a problem hiding this comment.
gflag自己有合法性检查的，定义了参数为uint32的话，指定其他类型参数会报错
| @@ -214,12 +277,21 @@ void CurveCli::PrintHelp(const std::string &cmd) { | |||
| } else if (cmd == kRemovePeerCmd || cmd == kTransferLeaderCmd) { | |||
| std::cout << "curve_ops_tool " << cmd << " -logicalPoolId=1 -copysetId=10001 -peer=127.0.0.1:8080:0 " // NOLINT | |||
| "-conf=127.0.0.1:8080:0,127.0.0.1:8081:0,127.0.0.1:8082:0 -max_retry=3 -timeout_ms=100" << std::endl; // NOLINT | |||
| } else if (cmd == kDoSnapshot) { | |||
| std::cout << "curve_ops_tool " << cmd << " -logicalPoolId=1 -copysetId=10001 -peer=127.0.0.1:8080:0 " // NOLINT | |||
There was a problem hiding this comment.
为什么提供了logicalpoolid和copysetid之后还要提供peer，这样使用这个命令需要先查询copyset的peer
There was a problem hiding this comment.
不通副本打快照是独立的，目前先提供这个功能，有需求给全部副本打快照再开发吧
Change-Id: Icf403e4beb5a2fb6532eae8e7de465dd085148cf
bai-charisu
force-pushed
the
tool-snapshot
branch
from
e8668b6
to
1290876
Compare
ilixiaocui
approved these changes
Dec 28, 2020
| CopysetID copysetId = request->copysetid(); | ||
| butil::Status st = | ||
| get_node(&node, logicPoolId, copysetId, | ||
| request->peer().address()); |
wu-hanqing
approved these changes
Dec 28, 2020
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
add Kubernetes project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Icf403e4beb5a2fb6532eae8e7de465dd085148cf
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List