fix bug that will not close _direct_fd #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hanqing
reviewed
Oct 9, 2020
| @@ -90,7 +90,8 @@ int CurveSegment::create() { | |||
| << "' with fd=" << _fd; | |||
| if (FLAGS_enableWalDirectWrite) { | |||
| _direct_fd = ::open(path.c_str(), O_RDWR|O_NOATIME|O_DIRECT, 0644); | |||
| LOG_IF(FATAL, _direct_fd < 0) << "failed to open file with O_DIRECT"; | |||
| LOG_IF(FATAL, _direct_fd < 0) << "failed to open file with O_DIRECT" | |||
| ", error: " << strerror(errno); | |||
There was a problem hiding this comment.
这里的strerror可以考虑用一下butil::berror，strerror在多线程的情况下，存在线程安全的问题。
bai-charisu
force-pushed
the
fix-close-direct
branch
from
f24d0fb
to
e658cfe
Compare
wu-hanqing
approved these changes
Oct 9, 2020
xu-chaojie
approved these changes
Oct 9, 2020
bai-charisu
force-pushed
the
fix-close-direct
branch
from
e658cfe
to
d7aef6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the bug that _direct_fd will not be close when segment destructed.
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List