curvefs: fix create copyset when exist already. #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
cw123
reviewed
Jan 17, 2022
| @@ -57,7 +57,7 @@ class CopysetNodeManager { | |||
|
|
|||
| virtual CopysetNode* GetCopysetNode(PoolId poolId, CopysetId copysetId); | |||
|
|
|||
| bool IsCopysetNodeExist(PoolId poolId, CopysetId copysetId); | |||
| int IsCopysetNodeExist(const CreateCopysetRequest::Copyset& copyset); | |||
There was a problem hiding this comment.
add meaning of return value
fixed
| } else { | ||
| auto copysetNode = iter->second.get(); | ||
| std::vector<Peer> peers; | ||
| copysetNode->ListPeers(&peers); |
There was a problem hiding this comment.
compare peer num
peers [1, 2, 3] peers[1, 2, 3, 4] is not same
There was a problem hiding this comment.
compare peer num
peers [1, 2, 3] peers[1, 2, 3, 4] is not same
fixed
…same will success, otherwise return exist.
SeanHai
force-pushed
the
create_copyset
branch
from
2b293c0
to
be91a72
Compare
cw123
approved these changes
Jan 18, 2022
wu-hanqing
reviewed
Jan 18, 2022
| bool exists = | ||
| manager_->IsCopysetNodeExist(copyset.poolid(), copyset.copysetid()); | ||
| if (exists) { | ||
| int exists = manager_->IsCopysetNodeExist(copyset); |
There was a problem hiding this comment.
another problem is above CreateCopysetNode will stop directly when failed to create one copyset, so you can find whether there's a good reason to continue creating all copysets and return status for each copyset.
wu-hanqing
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curvefs: fix create copyset when exist already. If peers are all the same will success, otherwise return exist.
What problem does this PR solve?
Issue Number: close #xxx
#998
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List