Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Transition from tap Diagnostic(...) to YAML(...) #533

Merged
merged 5 commits into from
Jan 11, 2018
Merged

*: Transition from tap Diagnostic(...) to YAML(...) #533

merged 5 commits into from
Jan 11, 2018

Commits on Jan 10, 2018

  1. vendor/github.com/mndrix/tap-go: Bump to 629fa40 

    To pick up t.YAML(...) for more visible error messages.  See ad47e7d
(Makefile: Change from prove to node-tap, 2017-11-30, opencontainers#439) about how
node-tap handles YAML blocks vs. diagnostics.

Generated with:

  $ go get -u github.com/mndrix/tap-go
  $ godep update github.com/mndrix/tap-go
  $ emacs Godeps/Godeps.json  # remove gopkg.in/yaml.v2 entry
  $ rm -rf vendor/gopkg.in/yaml.v2
  $ git add vendor/github.com/mndrix

We don't need gopkg.in/yaml.v2 because we're using tap-go's JSON
output.

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    0c66fe9 View commit details
    Browse the repository at this point in the history

  2. *: Transition from tap Diagnostic(...) to YAML(...) 

    See ad47e7d (Makefile: Change from prove to node-tap, 2017-11-30,
opencontainers#439) about how node-tap handles YAML blocks vs. diagnostics.

The README's localvalidation line is back after I accidentally removed
it in ad47e7d.

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    b880d57 View commit details
    Browse the repository at this point in the history

  3. validation/create: Label the state ID comparison test 

    So we get:

  ok 3 - 'state' MUST return the state of a container

instead of:

  ok 3 -

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    a12de42 View commit details
    Browse the repository at this point in the history

  4. validation/util/container: Use a local UUID for stdout/stderr 

    So validation/create.t gives:

  ok 4 - create MUST generate an error if the ID provided is not unique
    ---
    {
      "error": "exit status 1",
      "reference": "https://github.com/opencontainers/runtime-spec/blob/v1.0.0/runtime.md#create",
      "stderr": "container with id exists: 4a142dd0-e5bc-48b3-9abd-49c1a8f7c498\n"
    }
    ...

instead of:

  ok 4 - create MUST generate an error if the ID provided is not unique
    ---
    {
      "error": "open /tmp/ocitest842577116/stdout-178f8311-9cc7-42c5-b91e-abbe29eaf582: file exists",
      "reference": "https://github.com/opencontainers/runtime-spec/blob/v1.0.0/runtime.md#create"
    }
    ...

The old code hit the internal error, while the new code is checking
for a runtime error.

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    0c2e37e View commit details
    Browse the repository at this point in the history

  5. Makefile: Clearer warning on missing validation executable(s) 

    Instead of reporting

  total ................................................. 0/0

and passing (which node-tap seems to do when given missing files as
arguments), report:

  missing test executable; run 'make runtimetest validation-executables'

and error out.  Having a separate step to build the executables is
useful for:

* Not building them as root, which reduces the change of security
  issues by using as little privilege as possible.
* Not rebuilding them on each test, since we haven't told Make about
  the full dependency tree for the test executables.

The separate build step was introduced in e11b77f (validation: Use
prove(1) as a TAP harness, 2017-11-25, opencontainers#439), but I didn't do a good
job of motivating it in that commit message.

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    e85081a View commit details
    Browse the repository at this point in the history