Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/Makefile: fix test #947

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

zhouhao3
Copy link

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

@zhouhao3 zhouhao3 force-pushed the fix-makefile-test branch 2 times, most recently from acfa66c to d92e814 Compare January 22, 2018 08:47
Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that :/. “invalid document-file path” is not why the bad tests should be failing.

@wking
Copy link
Contributor

wking commented Feb 20, 2018

Bump :). This is blocking #942.

@crosbymichael
Copy link
Member

The tests are still failing with this one

@wking
Copy link
Contributor

wking commented Feb 22, 2018

@q384566678, can you rebase onto master to pick up #945 and avoid the current Travis error?

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Author

updated, @crosbymichael @hqhq PTAL

@hqhq
Copy link
Contributor

hqhq commented Feb 26, 2018

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Feb 26, 2018

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 7a8c2c8 into opencontainers:master Feb 26, 2018
@zhouhao3 zhouhao3 deleted the fix-makefile-test branch February 27, 2018 01:04
@vbatts vbatts mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants