-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema/Makefile: fix test #947
Merged
crosbymichael
merged 1 commit into
opencontainers:master
from
zhouhao3:fix-makefile-test
Feb 26, 2018
Merged
schema/Makefile: fix test #947
crosbymichael
merged 1 commit into
opencontainers:master
from
zhouhao3:fix-makefile-test
Feb 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhao3
force-pushed
the
fix-makefile-test
branch
2 times, most recently
from
January 22, 2018 08:47
acfa66c
to
d92e814
Compare
wking
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that :/. “invalid document-file path” is not why the bad tests should be failing.
The tests are still failing with this one |
@q384566678, can you rebase onto master to pick up #945 and avoid the current Travis error? |
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
zhouhao3
force-pushed
the
fix-makefile-test
branch
from
February 26, 2018 05:25
d92e814
to
9df387e
Compare
updated, @crosbymichael @hqhq PTAL |
1 similar comment
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com