config-linux: Drop redundant 'blkio' prefix from blockIO properties #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
remove-redundant-blkio
branch
from
f156aca
to
a70bd8f
Compare
|
I tend to keep them close to cgroup APIs, so +1 for closing this PR. |
|
If we want this before 2.0, it needs to go in the 1.0.0 milestone. If we don't want this before 2.0, and are ok with the currently-inconsistent controller-prefixing, then maintainers should close this issue with a note to that effect. The current maintainer comment seems to be in favor of controller-prefixing, and if we want to do that consistently (we don't at the moment, currently only for the |
These are long enough without the prefix, and linux.resources.blockIO.blkioWeight, etc. are just as specific as linux.resources.blockIO.weight. Generated with: $ sed -i s/blkioWeight/weight/g $(git grep -l blkioWeight) $ sed -i s/blkioLeaf/leaf/g $(git grep -l blkioLeaf) $ sed -i s/blkioThrottle/throttle/g $(git grep -l blkioThrottle) Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
remove-redundant-blkio
branch
from
a70bd8f
to
d8ca338
Compare
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are long enough without the prefix, and
linux.resources.blockIO.blkioWeight, etc. are just as specific aslinux.resources.blockIO.weight. Generated with:Property-name polishing inspired by #859, in case we want to clean this sort of thing up before 1.0. If not, we can just close this PR.