-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Bump Hyper-V condition from root.path to root itself #838
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ type Spec struct { | |
// Process configures the container process. | ||
Process *Process `json:"process,omitempty"` | ||
// Root configures the container's root filesystem. | ||
Root Root `json:"root"` | ||
Root *Root `json:"root,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This may fall under the no-pointers-if-required-on-any-platform policy that @mrunalp was going to document. If so, I can drop the pointer (and There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it make sense to have a In this case: keep There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We already have some policy wording for pointers, but they focus on input requirements. I think we also want to consider output requirements with Go's default JSON serializer, and would recommend:
as a new hole we'd want to poke in the current no-pointer preference. That would mean that we'd want |
||
// Hostname configures the container's hostname. | ||
Hostname string `json:"hostname,omitempty"` | ||
// Mounts configures additional mounts (on top of Root). | ||
|
@@ -94,7 +94,7 @@ type User struct { | |
// Root contains information about the container's root filesystem on the host. | ||
type Root struct { | ||
// Path is the absolute path to the container's root filesystem. | ||
Path string `json:"path,omitempty"` | ||
Path string `json:"path"` | ||
// Readonly makes the root filesystem for the container readonly before the process is executed. | ||
Readonly bool `json:"readonly,omitempty"` | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think POSIX here is also not suitable as in #835