Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-linux: Drop the default-filesystem section #678

Closed

Conversation

wking
Copy link
Contributor

@wking wking commented Feb 3, 2017

Users who need these mounts would have to explicitly set them up in their configuration (as runtime-tools continues to do) if they wanted to guarantee their presence. Users who don't need them can omit them from their configuration. I don't see how keeping a SHOULD-strength runtime requirement helps either of those workflows.

This is one of the possible approaches I'd floated in #666.

Users who need these mounts would have to explicitly set them up in
their configuration (as runtime-tools continues to do [1]) if they
wanted to guarantee their presence.  Users who don't need them can
omit them from their configuration.  I don't see how keeping a
SHOULD-strength runtime requirement helps either of those workflows.

[1]: opencontainers/runtime-tools#24

Signed-off-by: W. Trevor King <wking@tremily.us>
@hqhq
Copy link
Contributor

hqhq commented Feb 6, 2017

This section still looks useful to me.

@wking
Copy link
Contributor Author

wking commented Feb 6, 2017

This section still looks useful to me.

So do you prefer #679? Or do you like master how it is?

If you like master, do you read the current master wording as a suggestion to runtime authors or as a suggestion to config authors?

@crosbymichael
Copy link
Member

I prefer the master version

@wking
Copy link
Contributor Author

wking commented Feb 6, 2017

I prefer the master version

And I'm citing your earlier comment for the “this is advice to config authors” interpretation. Is that actually your interpretation? Do you think the master wording is clearly not advice to runtime authors (it's not clear to me)? It might be easier to talk about this if we talk over how SHOULD validation will work. Will this SHOULD be checked by runtime-tools' validate package (aimed at validating configuration JSON) or runtime-tools' runtimetest command (aimed at validating runtime implementations)?

@crosbymichael
Copy link
Member

Closing as this section is marked as SHOULD and is found useful by multiple maintainers.

wking added a commit to wking/nmbug-oci that referenced this pull request Jul 26, 2017
The mount-requirement was softened to a SHOULD in [1].  It's not clear
to me whether that SHOULD is directed at config authors ("you should
explicitly include mounts for these") or at runtimes ("you should
provide these even if the config doesn't ask for them"), but my
attempts to clarify that one way or the other were both rejected
[2,3].  The current runtime-tools and runC approach favors the
config-author direction [4], which is what I'd asked for in the
original thread post, so I'm tagging this obsolete.

[1]: opencontainers/runtime-spec#666
[2]: opencontainers/runtime-spec#679 (comment)
[3]: opencontainers/runtime-spec#678 (comment)
[4]: opencontainers/runtime-tools#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants