Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Add 'exit' to state for collecting the container exit code #677

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Contributor

@wking wking commented Feb 3, 2017

This gives us a more portable way to discover the container exit code (vs. requiring callers to use subreapers or other platform-specific approaches which require knowledge of the runtime implementation).

There would still be no portable way to discover when the container had exited (short of polling state), but we can handle that separately.

This gives us a more portable way to discover the container exit code
(vs. requiring callers to use subreapers [1] or other
platform-specific approaches which require knowledge of the runtime
implementation).

[1]: opencontainers/runc#827 (comment)

Signed-off-by: W. Trevor King <wking@tremily.us>
@crosbymichael
Copy link
Member

You cannot have this as required because that forces the runtime to always be running to update the state files.

This change just forces long running runtimes and will impact performance and usage down the road when you run at scale.

If you leave the runtime running it returns the container's exit status as its exit status anyway if you make that tradeoff. This does not belong in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants