Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: initial protobuf for config #185

Closed
wants to merge 8 commits into from

Commits on Sep 15, 2015

  1. proto: initial protobuf for structures

    To have a less source based, and more consumable example of structures,
    this is an initial pass at protobuf structures for the structures in the
    specs golang source.
    
    There is some exercise needed in platform specific structures.
    
    For the sake of example, the Makefile defaults to outputing golang
    source, but has a 'c' target (`make c`) for C source, a `make py` and
    `make all` target.
    
    This User structure does not map to the cleanliness of the current go
    structure, but will allow the definition to be all in one place,
    regardless of the host that is doing the compilation.
    
    All field rules to `optional` for now. Per vish and the docs,
    https://developers.google.com/protocol-buffers/docs/proto?csw=1#specifying-field-rules
    "! Required Is Forever"
    
    There are a couple of concessions, but is pretty much lined up.
    
    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    c57abfc View commit details
    Browse the repository at this point in the history
  2. proto/config: Explicit linux user message

    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    716ab56 View commit details
    Browse the repository at this point in the history
  3. proto/config: style guide

    https://developers.google.com/protocol-buffers/docs/style?hl=en
    
    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    68b2e0b View commit details
    Browse the repository at this point in the history
  4. proto: remove default values

    Let the user decide the value.
    
    opencontainers#179 (comment)
    
    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    0373e8f View commit details
    Browse the repository at this point in the history
  5. proto: default expanded enum to unknown

    per opencontainers#179 (comment)
    
    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    eb1d649 View commit details
    Browse the repository at this point in the history
  6. proto/config: User as extensions

    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Sep 15, 2015
    Configuration menu
    Copy the full SHA
    c0c399e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2015

  1. proto: example of json marshal

    Now the default make target shows json output from the example.go
    source.
    
    Consolidated the protobuf files due to a cyclic import issue.
    
    Cleaned up outputs to source respective outputs directories.
    
    Added a `cpp` target.
    
    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Sep 24, 2015
    Configuration menu
    Copy the full SHA
    50f8aa9 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2015

  1. protobuf: more full example

    * a more field out config structure
    * display using the jsonpb library
    * display the binary proto message
    
    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    vbatts committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    98100f5 View commit details
    Browse the repository at this point in the history