Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Config ] Mounts | type is underspecified #470

Closed
RobDolinMS opened this issue May 27, 2016 · 5 comments
Closed

[ Config ] Mounts | type is underspecified #470

RobDolinMS opened this issue May 27, 2016 · 5 comments
Milestone

Comments

@RobDolinMS
Copy link
Collaborator

The type parameter is a required string and this is defined for Linux however there is no information for Solaris and there is a suggestion of just using "ntfs" for Windows.

I don't know how important this parameter is for Linux, but if this is not defined for Solaris and there is only one value for Windows, maybe this should be optional; or required for Linux but otherwise optional?

@wking
Copy link
Contributor

wking commented May 27, 2016

On Fri, May 27, 2016 at 09:41:46AM -0700, Rob Dolin (MSFT) wrote:

I don't know how important this parameter is for Linux… maybe this
should be optional…

+1 on making it optional. See this ccon example where I don't set it
for bind mounts 1, and mount(2) describes MS_BIND with 2:

The filesystemtype and data arguments are ignored.

Obviously you'll still want to set 'type' when you mount a tmpfs or
some such ;).

@hqhq
Copy link
Contributor

hqhq commented Dec 24, 2016

Related to #303 , I'm tagging 1.0.0, any Solaris guys around?

@hqhq hqhq added this to the 1.0.0 milestone Dec 24, 2016
@jlbutler
Copy link
Member

jlbutler commented Jan 30, 2017

I believe this issue has been addressed via commits from @hqhq (1752ce8) and @anuthan (07b7958).

@RobDolinMS @jhowardmsft could you respond with whether or not this needs more work for Windows?

@lowenna
Copy link
Contributor

lowenna commented Feb 1, 2017

Looking at the first commit, I would strongly prefer type to be optional on Windows. It is not required.

@jlbutler
Copy link
Member

jlbutler commented Feb 9, 2017

@jhowardmsft does that mean that type is optional entirely, or if not supplied that the runtime implementation defaults to 'ntfs' and fills in the value in configuration metadata?

If the latter, I'd prefer we leave it as a REQUIRED field, where the implementation has a usability feature of filling a default in. If the type of file system is truly optional, that's a different story.

Note this passage has updated since the commit referenced above. It's still set REQUIRED but the description optionally allows for different filesystem types.

crosbymichael added a commit to crosbymichael/specs that referenced this issue Feb 27, 2017
These are optional on multiple platforms and should be left up to the
runtime/host system for validation.

Closes opencontainers#470

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael added a commit to crosbymichael/specs that referenced this issue Feb 28, 2017
These are optional on multiple platforms and should be left up to the
runtime/host system for validation.

Closes opencontainers#470

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@hqhq hqhq closed this as completed in #699 Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants