-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Config ] Mounts | type is underspecified #470
Comments
On Fri, May 27, 2016 at 09:41:46AM -0700, Rob Dolin (MSFT) wrote:
+1 on making it optional. See this ccon example where I don't set it The filesystemtype and data arguments are ignored. Obviously you'll still want to set 'type' when you mount a tmpfs or |
Related to #303 , I'm tagging |
I believe this issue has been addressed via commits from @hqhq (1752ce8) and @anuthan (07b7958). @RobDolinMS @jhowardmsft could you respond with whether or not this needs more work for Windows? |
Looking at the first commit, I would strongly prefer type to be optional on Windows. It is not required. |
@jhowardmsft does that mean that type is optional entirely, or if not supplied that the runtime implementation defaults to 'ntfs' and fills in the value in configuration metadata? If the latter, I'd prefer we leave it as a REQUIRED field, where the implementation has a usability feature of filling a default in. If the type of file system is truly optional, that's a different story. Note this passage has updated since the commit referenced above. It's still set REQUIRED but the description optionally allows for different filesystem types. |
These are optional on multiple platforms and should be left up to the runtime/host system for validation. Closes opencontainers#470 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
These are optional on multiple platforms and should be left up to the runtime/host system for validation. Closes opencontainers#470 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
The type parameter is a required string and this is defined for Linux however there is no information for Solaris and there is a suggestion of just using "ntfs" for Windows.
I don't know how important this parameter is for Linux, but if this is not defined for Solaris and there is only one value for Windows, maybe this should be optional; or required for Linux but otherwise optional?
The text was updated successfully, but these errors were encountered: