Skip to content

Commit

Permalink
runtime-linux: Condition /proc/self/fd symlinks on source existence
Browse files Browse the repository at this point in the history
Since 279c3c0 (linux: relax filesystem requirements for container,
2017-01-23, #666) it's no longer guaranteed that /proc will exist.
And there doesn't seem to be much point in requiring symlinks which
will be known broken.

This commit also tightens the timing.  Before it was just "after the
container has `/proc` mounted", which could have happened during the
'delete' operation (if the container authors wanted to be especially
ornery).  With this commit, I've put the creation in step 2 of the
lifecycle.  And within step 2, it happens after 'mounts' has been
processed.

Signed-off-by: W. Trevor King <wking@tremily.us>
  • Loading branch information
wking committed Mar 16, 2017
1 parent 4badf7f commit 3aa9eb8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runtime-linux.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Some of the file descriptors MAY be redirected to `/dev/null` even though they a

## <a name="runtimeLinuxDevSymbolicLinks" /> Dev symbolic links

After the container has `/proc` mounted, the following standard symlinks MUST be setup within `/dev/` for the IO.
While creating the container (step 2 in the [lifecycle](runtime.md#lifecycle)), runtimes MUST create the following symlinks if the source file exists after processing [`mounts`](config.md#mounts):

| Source | Destination |
| --------------- | ----------- |
Expand Down

0 comments on commit 3aa9eb8

Please sign in to comment.