Disable the subreaper on exec #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the flag but makes it hidden so that existing clients do not encounter an error if we were to have removed the flag. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
| @@ -115,7 +116,7 @@ func execProcess(context *cli.Context) (int, error) { | |||
| return -1, err | |||
| } | |||
| r := &runner{ | |||
| enableSubreaper: !context.Bool("no-subreaper"), | |||
| enableSubreaper: false, | |||
There was a problem hiding this comment.
remove this line as it because false is already the default value ?
There was a problem hiding this comment.
ya, just thought i would make it explicit. it was not omitted but set that way for a reason
|
LGTM |
|
@cyphar ya, that is why I didn't put Fixes ;) |
|
@crosbymichael This doesn't fix the exec reparent problem， still child process of the exec process，PPID becomes 0 ， after exec process exits. |
|
@sandyskies Yup, we know. Which is why #976 exists (as we discussed above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the flag but makes it hidden so that existing clients do not
encounter an error if we were to have removed the flag.
Linked to #971
Signed-off-by: Michael Crosby crosbymichael@gmail.com