Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reset failed systemd unit on OOM test #3802

Closed
wants to merge 1 commit into from

Conversation

lrascao
Copy link

@lrascao lrascao commented Apr 2, 2023

On centos stream9, when running the events oom test, systemd goes into a degraded state causing subsequent tests to fail, resetting the failed unit after the test fixes this. Not sure if this is the right fix but hopefully it's a step in the right direction to getting CI back to green.

$ RUNC_USE_SYSTEMD=true bats -t tests/integration/events.bats
$ [root@localhost runc]# systemctl --failed
  UNIT                                      LOAD   ACTIVE SUB    DESCRIPTION
● runc-cgroups-integration-test-29550.scope loaded failed failed libcontainer container integration-test-29550

several tests then start failing:

$ RUNC_USE_SYSTEMD=true bats -t tests/integration/ps.bats
# (in test file tests/integration/ps.bats, line 60)
#   `[[ "${lines[1]}" =~ [0-9]+ ]]' failed
# runc spec (status=0):
#
# runc run -d --console-socket /tmp/bats-run-85oCGW/runc.mWta7t/tty/sock test_busybox (status=0):
#
# runc state test_busybox (status=0):
# {
#   "ociVersion": "1.1.0-rc.1",
#   "id": "test_busybox",
#   "pid": 26325,
#   "status": "running",
#   "bundle": "/tmp/bats-run-85oCGW/runc.mWta7t/bundle",
#   "rootfs": "/tmp/bats-run-85oCGW/runc.mWta7t/bundle/rootfs",
#   "created": "2023-04-02T22:19:42.912423842Z",
#   "owner": ""
# }
# runc ps test_busybox -e -x (status=0):
#     PID TTY      STAT   TIME COMMAND
# /root/runc/tests/integration/ps.bats: line 60: lines[1]: unbound variable
ok 4 ps after the container stopped

systemctl reset-failed

@lrascao lrascao force-pushed the centos-stream9-ci-fix branch 3 times, most recently from 2452273 to 4d54ae3 Compare April 2, 2023 22:45
@lrascao
Copy link
Author

lrascao commented Apr 2, 2023

rebased on top of #3788, ci/centos-stream-9 is green now

@lrascao
Copy link
Author

lrascao commented Apr 3, 2023

rebased back onto main, CI will now fail as #3788 is missing now

Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
@kolyshkin
Copy link
Contributor

Thank you for your contribution! This was addressed by #3835 which does something like this and a bit more.

@kolyshkin kolyshkin closed this Apr 3, 2023
@kolyshkin
Copy link
Contributor

Thank you for your contribution! This was addressed by #3835 which does something like this and a bit more.

Sorry, I mean #3782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants