Add go 1.19, require go 1.18, drop go 1.17 #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
go119
branch
2 times, most recently
from
8e2e2d7
to
34e2375
Compare
4 tasks
|
OK, it seems to be working fine, except for golangci-lint (filed golangci/golangci-lint#2922) |
|
1.19 is GA now |
kolyshkin
changed the title
|
Alas we have to wait for a new golangci-lint release that has golangci/golangci-lint#2922 fixed. The fix is already merged but no release has been made yet (I guess it will be v1.48). |
kolyshkin
force-pushed
the
go119
branch
2 times, most recently
from
8e8aefe
to
f2116d5
Compare
|
Since I've already marked 1.19.x CI tests as required, can we please merge this? @opencontainers/runc-maintainers PTAL |
thaJeztah
reviewed
Aug 4, 2022
Since Go 1.19, godoc recognizes lists, code blocks, headings etc. It also reformats the sources making it more apparent that these features are used. Fix a few places where it misinterpreted the formatting (such as indented vs unindented), and format the result using the gofumpt from HEAD, which already incorporates gofmt 1.19 changes. Some more fixes (and enhancements) might be required. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This version works with go 1.19, i.e. it fixes golangci/golangci-lint#2922. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
@AkihiroSuda PTAL 🙏🏻 |
AkihiroSuda
approved these changes
Aug 16, 2022
|
@kolyshkin are you updating the repo settings? ("add test (1.19.x) to required list of tests (once this is merged)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes go 1.18 a minimally required version, removing go 1.17 from and adding go 1.19 to CI.
Also:
+buildtagstest (1.17.x)from the required set of teststest (1.19.x)to required list of tests (once this is merged)