Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: clean up remaining golangci-lint failures #2962

Merged
merged 2 commits into from
May 25, 2021
Merged

*: clean up remaining golangci-lint failures #2962

merged 2 commits into from
May 25, 2021

Commits on May 25, 2021

  1. *: clean up remaining golangci-lint failures 

    Most of these were false positives or cases where we want to ignore the
lint, but the change to the BPF generation is actually useful.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    @cyphar
    cyphar committed May 25, 2021
    Configuration menu
    Copy the full SHA
    07ca0be View commit details
    Browse the repository at this point in the history

  2. ci: lint: show all errors in PRs 

    It seems that golangci-lint didn't warn us about new lint errors that
were added after we enabled it, so just run the full thing and give us
all the errors on every PR run -- as long as we keep master lint-clean
it doesn't matter whether we set this or not.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    @cyphar
    cyphar committed May 25, 2021
    Configuration menu
    Copy the full SHA
    37767c0 View commit details
    Browse the repository at this point in the history