Implement hooks in libcontainer code base #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Signed-off-by: Mrunal Patel <mrunalp@gmail.com> Conflicts: libcontainer/integration/exec_test.go
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
|
👍 (cc @mavenugo) |
|
|
||
| type Hook interface { | ||
| // Run executes the hook with the provided state. | ||
| Run(*HookState) error |
There was a problem hiding this comment.
HookState very simple "immutable" struct. Can be passed everywhere by value to avoid confusion.
|
👍 to the function hooks idea |
| config.Hooks = &configs.Hooks{ | ||
| Prestart: []configs.Hook{ | ||
| configs.NewFunctionHook(func(s *configs.HookState) error { | ||
| f, err := os.Create(filepath.Join(rootfs, "test")) |
There was a problem hiding this comment.
dont think we should reach out to rootfs from here. We should pass it as hook state as @mrunalp mentioned before.
|
@crosbymichael I've tried to address the comments in this PR in calavera@00a65a1 Feel free to cherry pick it. Unfortunately, the poststop hook test is not working, I'm sure I'm missing something. |
crosbymichael
force-pushed
the
hooks
branch
from
9a5edce
to
4e20b76
Compare
Signed-off-by: David Calavera <david.calavera@gmail.com> Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
hooks
branch
from
4e20b76
to
0f28592
Compare
|
go vet failed. |
|
go vet is a lair! |
|
Ha ha |
|
LGTM |
|
@mrunalp we can update this again when we update the spec, i was just doing both independent so we would not be blocked |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Sep 11, 2015
Implement hooks in libcontainer code base
mavenugo
added a commit
to mavenugo/docker
that referenced
this pull request
Sep 11, 2015
libnetwork waiting on : moby/libnetwork#515 libcontainer waiting on : opencontainers/runc#261 Due to libseccomp challenges, I cherry-picked opencontainers/runc#261 on top of runc v0.0.3 which is seen in my private fork that is vendored-in here Signed-off-by: Madhu Venugopal <madhu@docker.com>
4 tasks
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Update Typo in ROADMAP.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little different implementation from #160 to have function based hooks for consumers of libcontainer directly but still supports our hooks for the spec based commands.