-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding oom_score_adj as a container config param #232
Conversation
cc @mrunalp |
// OomScoreAdj specifies the adjustment to be made by the kernel when calculating oom scores | ||
// for a process. Valid values are between the range [-1000, '1000'], where processes with | ||
// higher scores are preferred for being killed. | ||
// More information about kernel oom score calculation here: https://lwn.net/Articles/317814/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think could point to https://www.kernel.org/doc/Documentation/filesystems/proc.txt instead as oom_score_adj can't be found on the lwn page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Updated!
Also, you might want to propose this to the spec to expose it in the config :) |
Yes. The next PR will be add this to the Spec. |
waitProcess(&pconfig, t) | ||
outputOomScoreAdj := strings.TrimSpace(string(stdout.Bytes())) | ||
|
||
// Check that the groups output has the groups that we specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Good catch :)
On Fri, Aug 28, 2015 at 05:32:38PM -0700, Vish Kannan wrote:
Is a spec entry how we want to handle this? See |
Signed-off-by: Vishnu Kannan <vishnuk@google.com>
Ping @crosbymichael @LK4D4 |
LGMT |
LGTM |
Adding oom_score_adj as a container config param
No description provided.