tests: mask: use test paths rather than /sys #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain circumstances (such as the rootless containers patchset), it is not possible to test things using /sys/firmware. In addition, we should be testing our own functionality rather than testing protection against /sys attacks (for which the system might already have extra protections). Instead, just make some fake paths in the rootfs that we then mask. Oddly I noticed that one of the errors changed when doing this (because before we tested removing a file from /sys/firmware which is -EPERM). So the old test was broken. Fixes: 5317955 ("MaskPaths: support directory") Fixes: #1068 Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain circumstances (such as the rootless containers patchset), it
is not possible to test things using /sys/firmware. In addition, we
should be testing our own functionality rather than testing protection
against /sys attacks (for which the system might already have extra
protections).
Instead, just make some fake paths in the rootfs that we then mask.
Oddly I noticed that one of the errors changed when doing this (because
before we tested removing a file from /sys/firmware which is -EPERM). So
the old test was broken.
Fixes: 5317955 ("MaskPaths: support directory")
Fixes: #1068
Signed-off-by: Aleksa Sarai asarai@suse.de