Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stop command #681

Closed
mikebrow opened this issue Mar 23, 2016 · 3 comments
Closed

Add stop command #681

mikebrow opened this issue Mar 23, 2016 · 3 comments

Comments

@mikebrow
Copy link
Member

The spec has a requirement for the inclusion of a stop command. The spec states:

Stop

stop <container-id>

This operation MUST generate an error if it is not provided the container ID. This operation MUST stop
and delete a running container. 

Stopping a container MUST stop all of the processes running within the scope of the container. 

Deleting a container MUST delete the associated namespaces and resources associated with the container. 

Once a container is deleted, its id MAY be used by subsequent containers. 

Attempting to stop a container that is not running MUST have no effect on the container and MUST generate an error.

I volunteer to do a PR for this new command. Objections?
@crosbymichael
Copy link
Member

I dont remember this. Stop is pretty bad because what does stop mean? TERM? SIGKILL? We don't want logic like docker where you SIGTERM, wait for it to die then after a timeout do a SIGKILL.

@mikebrow
Copy link
Member Author

kk... probably need to move the issue to the spec then...

@mikebrow mikebrow mentioned this issue Mar 23, 2016
Closed
@crosbymichael
Copy link
Member

Ok, lets close this then to not cause anyone confusion while its being discussed.

wking referenced this issue in opencontainers/runtime-spec Apr 5, 2016
Split create and start
84bb619 
Also renamed "stop" to "delete" this way if we split it into stop & delete
later on then delete is still pretty much the same.

Signed-off-by: Doug Davis <dug@us.ibm.com>
stefanberger pushed a commit to stefanberger/runc that referenced this issue Sep 8, 2017
Merge pull request opencontainers#681 from wking/valid-values
be3a184 
config: Move valid-value rules to their own section
stefanberger pushed a commit to stefanberger/runc that referenced this issue Sep 8, 2017
@wking
config: Remove "MAY support any valid values" sentence
76c740e 
This line landed in 718f9f3 (origin/pr/673) minor narrative cleanup
regarding config compatibility, 2017-01-30, opencontainers#673), but I'm not clear
on the motivation.  The wording reads to me like "you don't have to
support valid values for platform-specific fields if you don't want
to", but we already cover unsupported value handling with the "MUST
generate an error when invalid or unsupported values are encountered"
language separated out in c763e64 (config: Move valid-value rules to
their own section, 2017-02-07, opencontainers#681).  This commit removes the
ambiguous line.

Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crosbymichael @mikebrow