.pullapprove.yml: Switch to v2 and other project-template updates #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wking looks to be a good start, but shouldn't github_reviews be set to true? |
|
On Mon, Mar 20, 2017 at 11:06:03AM -0700, Chris Aniszczyk wrote:
@wking looks to be a good start, but shouldn't github_reviews be set
to true?
https://docs.pullapprove.com/groups/github_reviews/
It defaults to true; see the “Defaults” section in the docs you linked
and my earlier comment [1].
[1]: opencontainers/project-template#29 (comment)
|
Pull in changes from [1]. The only changes vs. the upstream version are: * Kept the image-spec-specific approve_regexp. * Removed all the groups except for the image-spec group. [1]: opencontainers/project-template#29 Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM cc: @opencontainers/image-spec-maintainers |
|
On Mon, Mar 20, 2017 at 01:34:20PM -0700, Chris Aniszczyk wrote:
LGTM…
Hmm. I don't think PullApprove should have counted that [1,2]. Maybe
you need to remove yourself from the image-spec-maintainers team? Or
maybe we're missing a switch to tell PullApprove to not count repo
admins unless they're in a listed team? Or maybe there's no way to
get PullApprove to skip your non-maintainer LGTM and anyone hitting
the merge button should be watching out for those manually? Or maybe
the image-spec maintainers should just vote you in as a maintainer :).
[1]: https://pullapprove.com/opencontainers/image-spec/pull-request/616/reviews/
[2]: https://github.com/opencontainers/image-spec/blob/d24a3c9dc8781be1e08962c4f91aa86f5697fe81/MAINTAINERS
|
|
Hmm, does the PR with changes to pull-approve accept the changes in pull-approve as the criteria for approval? |
stevvooe
approved these changes
Mar 20, 2017
|
Looks like not! LGTM |
|
lgtm |
jonboulle
added a commit
to jonboulle/image-tools
that referenced
this pull request
Apr 6, 2017
This lazily copies image-spec's configuration as updated via opencontainers/project-template#29 and opencontainers/image-spec#616 Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in changes from opencontainers/project-template#29. The only changes vs. the upstream version are:
approve_regexp.After this PR lands, PullApprove will start treating @jbouzane's review-approvals as LGTM votes.